qiime2 / q2-composition

BSD 3-Clause "New" or "Revised" License
5 stars 28 forks source link

Bokeh plot appears to be broken #56

Closed thermokarst closed 6 years ago

thermokarst commented 6 years ago

Description The bokeh plots embedded in the viz appear to be broken - the console warning says "[bokeh] could not set initial ranges".

Steps to reproduce the behavior

  1. Open this example plot
  2. Open browser's developer console.

Expected behavior The Bokeh plot should be present and not empty. There should be no errors in the dev console.

Screenshots screen shot 2018-07-17 at 5 59 01 am

Computation Environment

References

  1. Original forum post
  2. Second forum post
ebolyen commented 6 years ago

Any reason we couldn't turn this into a Vega plot? It think it should work pretty well.

thermokarst commented 6 years ago

Good idea! What if this update was rolled into our vega brown-bag luncheon for when @nbokulich is in town?

ebolyen commented 6 years ago

I love it!

On Tue, Jul 17, 2018 at 10:12 AM, Matthew Dillon notifications@github.com wrote:

Good idea! What if this update was rolled into our vega brown-bag luncheon for when @nbokulich https://github.com/nbokulich is in town?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/qiime2/q2-composition/issues/56#issuecomment-405657500, or mute the thread https://github.com/notifications/unsubscribe-auth/ADyuZF2HogtAM529lmMNcMqEowT2o1Ksks5uHhr1gaJpZM4VSzNA .

mortonjt commented 6 years ago

In the meantime - do you guys think an appropriate solution would be to recommend users to fix their bokeh version until the next release?

ebolyen commented 6 years ago

Yeah that should be fine. And actually, we could probably fix our release environment file the same way manually in the interim.

thermokarst commented 6 years ago

PR for pinning the version in the 2018.6 env files: https://github.com/qiime2/environment-files/pull/4

As far as the docs go, I think @ebolyen was planning on rebuilding the 2018.6 docs to include the new copy-to-clipboard commands. If he does that with the patched env, the published visualizations should be back in order.

ebolyen commented 6 years ago

Yup, I'll be getting to that in the next day or two.