qiime2 / q2-composition

BSD 3-Clause "New" or "Revised" License
5 stars 27 forks source link

IMP: adds `filter_missing` flag to ancom #92

Closed valentynbez closed 1 year ago

valentynbez commented 1 year ago
valentynbez commented 1 year ago

Not sure what is happening, the command py.test --pyargs q2_composition runs on my machine without errors

lizgehret commented 1 year ago

Thanks for implementing these changes @valentynbez! I've fixed the merge conflicts and removed the logging (QIIME 2 doesn't have the ability to utilize that) - I think there is a small test failure just due to regex matching, but I'll pull this down locally and test on my end to confirm. Otherwise this should be good to go!

valentynbez commented 1 year ago

Thanks for looking into it!

lizgehret commented 1 year ago

I added one small fix just on the ID sorting in your error branch, but this is otherwise good to go! Thanks @valentynbez 🙂