qiime2 / q2-dada2

QIIME 2 plugin wrapping DADA2
BSD 3-Clause "New" or "Revised" License
19 stars 36 forks source link

Update DADA2 1.8.0 #103

Closed ebolyen closed 5 years ago

ebolyen commented 5 years ago

It looks like an OS X build was pushed for 2.48.0 (but not for linux). Since bioconda doesn't have a way to synchronize the bionconductor packages the bionconductor-dada2 package is pulling in the latest biostrings which won't work as that package hasn't been rebuilt yet with the namespace changes found here:

https://github.com/benjjneb/dada2/commit/85846e89bce8970a920bb492ae5108e79b8ab395#diff-7347fe5a0f184f79ef064e92e3beb297

This should fix https://busywork.qiime2.org/teams/main/pipelines/master-distribution/jobs/integration/builds/16 in the interim.

ebolyen commented 5 years ago

Actually, we might hold off on this: https://github.com/bioconda/bioconda-recipes/issues/11315

It sounds like we might have the latest DADA2 available shortly which would be way better :)

ebolyen commented 5 years ago

New DADA2 is live! Ready for merge.

benjjneb commented 5 years ago

Hooray! When I get time (hopefully in Nov) I should be able to push script updates that close about half the open issues now that 1.8 is in.