search

qiime2 / q2-dada2

QIIME 2 plugin wrapping DADA2
BSD 3-Clause "New" or "Revised" License
19 stars 36 forks source link

IMP: Expose new match_ids parameter #121

Closed Oddant1 closed 4 years ago

Oddant1 commented 4 years ago

closes #118. This currently adds no new unit tests because honestly I'm not 100% on what this behavior is meant to do (it seems to have something to do with mixed orientation), but it does expose the new parameter. Additionally, I'm not positive that it's actually being sent to R properly (in fact I have a strong suspicion it isn't) because I've never tried to do this before, but it's a start.

ebolyen commented 4 years ago

This PR would need to involve editing the R scripts located in assets as well.

Oddant1 commented 4 years ago

@ebolyen yeah I figured as much, I don't really know how that works, but I can figure it out

Oddant1 commented 4 years ago

@ebolyen is this the correct modifications of the R script? Seems like all I needed to do was put the arg in a variable then pass it off.

thermokarst commented 4 years ago

Hey there @ChrisKeefe, can you please review this PR when you get a chance? Please address any changes you might want made to @ebolyen & I - we are teaming up to run this one across the finish line!

ebolyen commented 4 years ago

This is probably best addressed by https://github.com/qiime2/q2-types/issues/207, closing for now.