search

qiime2 / q2-dada2

QIIME 2 plugin wrapping DADA2
BSD 3-Clause "New" or "Revised" License
19 stars 36 forks source link

Issue 117 #130

Closed Oddant1 closed 3 years ago

Oddant1 commented 4 years ago

closes #117

Oddant1 commented 4 years ago

I'm not sure what's going on with the tests in https://github.com/qiime2/q2-dada2/pull/130/commits/eada3649abbd1cc95aa1e327592ac0f7a996723a. They were passing, then failing, then passing again, now they're failing again, and I haven't really touched the code along the way.

Oddant1 commented 4 years ago

The tests are failing on master too so :man_shrugging:

thermokarst commented 4 years ago

@Oddant1, did you resolve the issues here, or maybe you would like some assistance? Feel free to assign to me.

Oddant1 commented 4 years ago

@thermokarst nope, I have no idea. Things seem to be passing or failing at random between runs. Locally my dada2 tests were failing on all branches. Then I restarted my computer and they started passing again. I've run the tests on this branch locally a few times since restarting my computer, and they've passed every time. Before restarting I was getting the same errors that travis is seeing right now.

Oddant1 commented 4 years ago

Thanks @ebolyen for demystifying the reason my environment was misbehaving while trying to troubleshoot this issue. Once that was figured out, the actual problem was easy to resolve (I forgot to pass the newly added param off to R eyeroll). Should be good to go now.