search

qiime2 / q2-dada2

QIIME 2 plugin wrapping DADA2
BSD 3-Clause "New" or "Revised" License
18 stars 36 forks source link

Add warning when pooling method and chimera detection method are misaligned #165

Open benjjneb opened 2 months ago

benjjneb commented 2 months ago

Improvement Description Provide a warning to the user when --p-pooling-method and --p-chimera-method are misaligned. In particular, --p-chimera-method pooled should only be used when --p-pooling-method pooled, otherwise the correctly aligned chimera removal method is --p-chimera-method concensus.

Current Behavior No check is made.

Proposed Behavior Warn the user when the pooling method and chimera method are misaligned.

References

  1. https://github.com/benjjneb/dada2/issues/1942
lizgehret commented 1 month ago

Hey @benjjneb, thanks for bringing this up! I think more realistically this should be an error (vs. a warning) - we should be able to do this with a TypeMap. I'll get this added to our upcoming release board and we'll work on this for 2024.10!