gregcaporaso
commented
8 years ago I can review this one today.
Sent from my phone, please excuse typos and brevity.
On Oct 26, 2016 12:21 AM, "benjjneb" notifications@github.com wrote:
fixes #19 https://github.com/benjjneb/q2-dada2/issues/19
Added the max_ee and truncq filtering parameters to the plugin.
Works for me on my local machine, but as this is the first time I'm changing any python code, could @gregcaporaso https://github.com/gregcaporaso or @ebolyen https://github.com/ebolyen
review/merge this?
You can view, comment on, or merge this pull request online at:
https://github.com/benjjneb/q2-dada2/pull/20 Commit Summary
- Added max_ee and truncq parameters
- Add R/dada2 version reporting in stdout
File Changes
- M q2_dada2/_denoise.py https://github.com/benjjneb/q2-dada2/pull/20/files#diff-0 (4)
- M q2_dada2/assets/run_dada.R https://github.com/benjjneb/q2-dada2/pull/20/files#diff-1 (9)
- M q2_dada2/plugin_setup.py https://github.com/benjjneb/q2-dada2/pull/20/files#diff-2 (2)
Patch Links:
- https://github.com/benjjneb/q2-dada2/pull/20.patch
- https://github.com/benjjneb/q2-dada2/pull/20.diff
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/benjjneb/q2-dada2/pull/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AALvdFklfUaZ9m5oi-DaXPrt0mcbXlNOks5q3v9ngaJpZM4Kg1ij .
fixes #19
Added the max_ee and truncq filtering parameters to the plugin.
Works for me on my local machine, but as this is the first time I'm changing any python code, could @gregcaporaso or @ebolyen review/merge this?