search

qiime2 / q2-dada2

QIIME 2 plugin wrapping DADA2
BSD 3-Clause "New" or "Revised" License
19 stars 36 forks source link

Verify that sample-ids with underscore characters are preserved #46

Closed ebolyen closed 7 years ago

ebolyen commented 7 years ago

This came up on the forum.

I need to verify this behavior, however I believe it's probably the result of this plugin.

benjjneb commented 7 years ago

This probably derives from the way the file-names are parsed by the python script: https://github.com/qiime2/q2-dada2/blob/master/q2_dada2/_denoise.py#L72

Right now it looks like files are assumed to be named in SAMPLENAME_XXX.fastq.gz format.

ebolyen commented 7 years ago

That looks like it! It should probably be using rsplit with a cut-off.

ebolyen commented 7 years ago

Looks like we ran into this again. I'll try and prioritize this for the May release.