expose minimum-length parameter?

qiime2 / q2-dada2

QIIME 2 plugin wrapping DADA2

BSD 3-Clause "New" or "Revised" License

19 stars 36 forks source link

expose minimum-length parameter? #72

Closed jairideout closed 5 years ago

jairideout commented 7 years ago

Question came up on the forum about whether we should expose the minimum-length parameter in q2-dada2. Current behavior is minimum-length=20.

nbokulich commented 5 years ago

forum xref

benjjneb commented 5 years ago

Can sequences be filtered out if they are below a minimum length by filter-features?

If so, I think it is preferable to leave this functionality to that plugin rather than adding another parameter here.

ebolyen commented 5 years ago

We don't have functionality for that, but it is a good idea. I think it would go in filter-seqs and then you could treat that as a set of ids for filter-features.

benjjneb commented 5 years ago

OK, I am changing this to wont-fix here then, as I think the best solution would be to put this functionality in filter-seqs or filter-features. I'll leave it open though until an issue is created at whatever the right location would be for that plugin.

thermokarst commented 5 years ago

xref: https://github.com/qiime2/q2-feature-table/issues/151