search

qiime2 / q2-deblur

BSD 3-Clause "New" or "Revised" License
2 stars 22 forks source link

Bump minimum version req #60

Closed wasade closed 6 years ago

wasade commented 6 years ago

@thermokarst, I'm looking at doing a test case here but it'll need to be a bit contrived. Don't have a solution exactly yet.

thermokarst commented 6 years ago

Sorry @wasade for letting this sit for so long - I was traveling last week, but am back in the office now.

thermokarst commented 6 years ago

Thanks @wasade! Looks great! No worries on the tests.

thermokarst commented 6 years ago

Busywork just failed on integration due to a hard version pin in this version of deblur:

UnsatisfiableError: The following specifications were found to be in conflict:

  - q2-alignment=2018.4.0.dev0 -> mafft[version='>=7.310']

  - q2-deblur=2018.4.0.dev0+1.g9d1c639 -> deblur[version='>=1.0.4'] -> mafft==7.221

Is there any way the deblur pin can be loosened up a bit?

wasade commented 6 years ago

No worries! And yes, see https://github.com/biocore/deblur/blob/master/.travis.yml#L14

thermokarst commented 6 years ago

Ah, thanks @wasade. It looks like there might be an inconsistency between that travis spec, and the conda build recipe for deblur. I will cut a PR for updating the recipe.

thermokarst commented 6 years ago

Related PR available here: https://github.com/biocore/conda-recipes/pull/120