search

qiime2 / q2-demux

BSD 3-Clause "New" or "Revised" License
0 stars 20 forks source link

Ignore description mismatch #123

Closed wasade closed 4 years ago

wasade commented 4 years ago

This pull request exposes an option to allow for ignoring sequence record description mismatches. It came about from applying q2-demux to all of the sequencing runs from the AGP, and observing that at least one sequencing run had mismatches in the description fields but the IDs otherwise matched.

One note, the seqs iterator is implicitly constructed so I could not see a way to easily pass in a parameter. Instead, the flag on the instance is toggled within the API methods.

Separately, the BarcodePairedSequenceFastqIterator object did not have tests for description mismatch so those were added.

wasade commented 4 years ago

Ugh, I apologize, this PR inadvertently carried over commit 0c8b99e. I'm closing and rebasing.