search

qiime2 / q2-demux

BSD 3-Clause "New" or "Revised" License
0 stars 20 forks source link

add `tabulate-counts` action #151

Closed gregcaporaso closed 1 year ago

gregcaporaso commented 1 year ago

This adds a new action, tabulate-counts, which reads one or more demux artifacts and generates an ImmutableMetadata artifact with the per-sample sequence counts.

Fixes #150.

wasade commented 1 year ago

Seems good pending CI, this is super helpful to have!

gregcaporaso commented 1 year ago

Thanks @wasade! These failures seem unrelated, so we'll get those sorted out independently of this PR.

gregcaporaso commented 1 year ago

I'm thinking a better name for this would be tabulate-reads tabulate-read-counts, since counts are really the outcome, not what's being tabulated. Converting this to a draft PR until I make a decision on that.

gregcaporaso commented 1 year ago

Linting should pass after #152 is merged.

Oddant1 commented 1 year ago

@gregcaporaso I fixed the merge conflicts is this ready to merge?

gregcaporaso commented 1 year ago

Yep, this is ready to go!

gregcaporaso commented 1 year ago

I just added a note to the draft release notes on this one.