Closed wasade closed 3 years ago
BTW, I sorted out the CI issues, you might need a refresh from master
.
Thanks @thermokarst!!
Hey @wasade - I got the CI back in order, looks like there is a legit test failure. Let me know if you want me to take a look at it.
Actually, looks like maybe that is unrelated to the changeset here? @wasade, can you comment on this - do you know if the phylo/table mis-match error msg changed in the latest release of unifrac?
cc @ChrisKeefe
biocore/unifrac#106 I think? These extra validations were added
Thanks for the reminder @wasade, looks like @ChrisKeefe left some breadcrumbs here - I'll push a commit up to this feature branch sometime soon to address.
Excellent!!
This is a work in progress pull request that exposes
unifrac.meta
. Would it be possible to get a very quick comment on the approach to handling the passthrough? I wanted to make sure this approach was reasonable before getting the rest of the bits finalized.The TODO items that I'm aware of are:
beta_phylogenetic
)meta
specific arguments@ebolyen and @thermokarst, per the discussion on handling paired inputs on Slack, I'd be happy to revise this to reflect the
:
syntax but also wanted to get something tentatively in while that discussion solidifies. I'd also be happy to submit a PR toq2cli
to support the:
syntax if that is considered a blocker for this PR, although I may need some guidance there as (at the moment) am not very familiar with that codebase.