qiime2 / q2-diversity

BSD 3-Clause "New" or "Revised" License
4 stars 45 forks source link

suggestions for future work on `alpha-rarefaction` visualizer #130

Open jairideout opened 7 years ago

jairideout commented 7 years ago

Improvement Description The new alpha-rarefaction visualizer @maxvonhippel authored is almost ready for merge (#128) and will be included in the 2017.8 release! :tada:

When reviewing #128 I had some suggestions for future work on the visualizer, but they are outside the scope of #128 so I'm posting them here. We can split this issue into smaller issues whenever we get around to working on these changes.

Proposed Behavior

References

  1. 128

  2. https://github.com/qiime2/q2-diversity/pull/158
  3. 179

jairideout commented 7 years ago

These suggestions also came up on the forum.

antgonza commented 7 years ago

Thanks for putting this together. One more suggestion, store intermediary files (rarefied tables and their alpha div vectors).

maxvonhippel commented 7 years ago

I like potentially providing the option to store intermediary files, though for performance reasons I would prefer not to have it be the default. The "deselect all" idea, scrollbar, and help text could make for a good/easy/fast joint PR, IMO. RE The first point about providing multiple metrics - I think that we will/can allow this but we had to wait for Set to be fully supported in the q2cli and in Provenance ... am I right that this was the hang-up, @ebolyen ?

ebolyen commented 7 years ago

Re: intermediary files. That falls in line with turning this action into a pipeline (which is now supported, and planned for the near future).

And for multiple metrics, that is now supported as of 2017.10. (although sets still look a bit ugly in provenance, but they are accurate according to yaml spec)

jairideout commented 7 years ago

Grouping the intermediate file comments:

Thanks for putting this together. One more suggestion, store intermediary files (rarefied tables and their alpha div vectors).

I like potentially providing the option to store intermediary files, though for performance reasons I would prefer not to have it be the default.

Re: intermediary files. That falls in line with turning this action into a pipeline (which is now supported, and planned for the near future).

:+1: for an option to store intermediate files. This feature can't be implemented right now because the QIIME 2 framework doesn't support variadic outputs, so there's a missing piece even though Pipelines are now supported.

@maxvonhippel I'll update the issue to indicate which bullet points have been completed (e.g. the work @jakereps did with Set support and multiple metrics).

gregcaporaso commented 7 years ago

The recommendation of starting with the median frequency per sample as max-depth seems pretty reasonable based on a few studies that I've been working on. It might be worth making this a default, and including recommendations on when to change it in the associated documentation. Otherwise we can expect this to come up as a question a lot (eg).

nbokulich commented 6 years ago

another suggestion from the forum:

allow user-defined coloring

maxvonhippel commented 6 years ago

@nbokulich that makes sense as a feature since it reflects colorization options in other plugins such as Emperor.

That said, the design might not be completely straightforward. Do we provide a list of palette options? Do we allow the user to upload some sort of palette file? (Is there a standard format for palette files, which could map deterministically to specific values in the plot?) Maybe these questions have all already been answered in the development of some other QIIME 2 code; I'm not sure.

nbokulich commented 6 years ago

@maxvonhippel emperor could be a model for this (i.e., support interactive palettes).

However, I am naive to how the plots are being generated and if that requires fundamental changes (e.g., switching to something like d3), it is probably not worth it. For users who need such a feature to generate publication-quality figures, manual color changing would be equally straightforward in Adobe Illustrator or equivalent free image editing software.

maxvonhippel commented 6 years ago

@nbokulich in this visualizer we are already generating the plots with d3. That said, I agree about manual color changing, especially with the .svg files.

jairideout commented 6 years ago

forum x-ref

That forum topic pertains to this bullet point:

When metadata is provided, add a UI element to disable grouping by metadata category. That way, users can get a per-sample (ungrouped) plot without having to regenerate the visualization sans metadata.

ebolyen commented 6 years ago

forum x-ref re: export option

thermokarst commented 6 years ago

This recently came up on the forum (re: export option)