search

qiime2 / q2-diversity

BSD 3-Clause "New" or "Revised" License
4 stars 45 forks source link

ENH: Add procrustes analysis plugin #194

Closed ElDeveloper closed 6 years ago

ElDeveloper commented 6 years ago

Solves the procrustes problem for two ordination matrices. While we can support N different matrices as inputs, we can't support varidic outputs, hence this will be deferred to a later PR when the functionality is available in the framework.

ebolyen commented 6 years ago

Heads up for whoever does the final merge: this may happen before or after we get all the citations set up for q2-diversity, so either remember to add them to this PR (with a rebase), or make sure the q2-diversity citation PR includes the citations for this method.

thermokarst commented 6 years ago

I pushed up a small diff with the changes I requested in my review - if those look okay to you, please let me know - I will merge ASAP. Otherwise, feel free to revert, patch, invert, subvert, or whatever the git subcommand is for undoing my changes. Thanks @ElDeveloper! 🎉

ElDeveloper commented 6 years ago

Can't seem to be able to approve the changes, but it all looks good to me, thanks for having a look! 👍