qiime2 / q2-diversity

BSD 3-Clause "New" or "Revised" License
4 stars 45 forks source link

BUG: adonis, normalize MD header #239

Closed thermokarst closed 5 years ago

thermokarst commented 5 years ago

This could also be 'sample-id' - thoughts?

ElDeveloper commented 5 years ago

+1, although it is now solved, in older versions of pandas, there was a bug with the index name setters; this lead to a similar unit test being added to emperor.

On (Feb-13-19|14:10), Nicholas Bokulich wrote:

nbokulich requested changes on this pull request.

Thanks @thermokarst ! One question: should we add a unit test just for the fun of it?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/qiime2/q2-diversity/pull/239#pullrequestreview-203474603