qiime2 / q2-diversity

BSD 3-Clause "New" or "Revised" License
4 stars 45 forks source link

ENH: alpha_correlation should have intersect_ids parameter #259

Closed tkosciol closed 5 years ago

tkosciol commented 5 years ago

Improvement Description similarly to qiime2.plugins.diversity.pipelines.beta_correlation, qiime2.plugins.diversity.visualizers.alpha_correlation should have the intersect_ids parameter

Current Behavior Currently, for mismatches between alpha vector and metadata the visualizer produces an error

Proposed Behavior intersect_ids and run alpha correlation only on a subset matching between both

thermokarst commented 5 years ago

I like this idea, thanks! @tkosciol, you are welcome to tackle this, just let us know. In the meantime, I will ping @David-Rod & @Oddant1 to see if they are interested, too.

tkosciol commented 5 years ago

@thermokarst happy to take a stab at it!

thermokarst commented 5 years ago

Fixed in #261