search

qiime2 / q2-diversity

BSD 3-Clause "New" or "Revised" License
4 stars 45 forks source link

Bioenv 0 variance filter #276

Closed Oddant1 closed 4 years ago

Oddant1 commented 4 years ago

closes #275

andrewsanchez commented 4 years ago

This seems fine to me if jumping between QIIME 2 objects and pandas DataFrames is a common/acceptable pattern. Is that the case?

However, should we consider extending Metadata.filter_ids to handle stuff like this? Even so, I'm good with merging this now and handling opening another issue for that.

thermokarst commented 4 years ago

This seems fine to me if jumping between QIIME 2 objects and pandas DataFrames is a common/acceptable pattern. Is that the case?

It isn't ideal, but its not a showstopper, in my opinion. I would love to see a new filter added to Metadata, though, that would be a sweet addition.

andrewsanchez commented 4 years ago

This seems fine to me if jumping between QIIME 2 objects and pandas DataFrames is a common/acceptable pattern. Is that the case?

It isn't ideal, but its not a showstopper, in my opinion. I would love to see a new filter added to Metadata, though, that would be a sweet addition.

Cool, then I'll go ahead and merge this then open a new ENH issue on the framework about adding a new filter.