qiime2 / q2-diversity

BSD 3-Clause "New" or "Revised" License
4 stars 45 forks source link

ENH: Route all alpha and beta diversity calculations through q2-diversity-lib #280

Closed ChrisKeefe closed 4 years ago

ChrisKeefe commented 4 years ago

Improvement Description The following Actions should be made into Pipelines, dependent on Actions from q2-diversity-lib:

q2-diversity-lib, in turn, will dispatch these calls to the best available implementation of the requested method. See https://github.com/qiime2/q2-diversity-lib/issues/22

Current Behavior core-metrics and core-metrics-phylogenetic call methods from q2-diversity-lib for alpha and beta diversity calculations. The alpha and beta Actions, however, are called directly from q2-diversity.

This proposal makes q2-diversity-lib uniquely responsible for determining what implementation of a given method should be used. This allows q2-diversity to stop caring about what methods have been implemented/constrained in q2-diversity-lib at any given moment, and which methods will simply be passed through to an appropriate dependency.

Proposed Behavior

Comments

  1. This will likely require minor changes to other Actions that use these functions - e.g. alpha_phylogenetic
thermokarst commented 4 years ago

Please see https://github.com/qiime2/q2-diversity/pull/281#issuecomment-665974036 for some modifications to this plan.