search

qiime2 / q2-diversity

BSD 3-Clause "New" or "Revised" License
4 stars 45 forks source link

BUG: x-axis data missing in alpha rarefaction viz #360

Closed lizgehret closed 4 months ago

lizgehret commented 4 months ago

fixes #359

So this does work, but I'm not happy with the fact that this had to be added (seemingly) randomly. I'm signing off for the day, but will try to find a better solution that addresses what changed from 2024.2 to 2024.5 tomorrow.

Oddant1 commented 4 months ago

@lizgehret the image in this viz is in svg, so each element of the viz has actual DOM nodes. That means in theory we can test it with selenium. If we are patching, we shouldn't hold up the patch for that, but it's probably worth adding those tests. If only they had been added ages ago lol.

lizgehret commented 4 months ago

@lizgehret the image in this viz is in svg, so each element of the viz has actual DOM nodes. That means in theory we can test it with selenium. If we are patching, we shouldn't hold up the patch for that, but it's probably worth adding those tests. If only they had been added ages ago lol.

I agree on both counts - we should add tests, but we should wait until after the patch to do so. Want to walk me through selenium testing next week when I'm back in office?

Oddant1 commented 4 months ago

Sure

lizgehret commented 4 months ago

update 1: viz works as expected without metadata as input.

update 2: this is the culprit. the updated fix ensures that these names match the multi-index DF, so that the names aren't overwritten in the case that they don't match up when the merge occurs.