Closed lizgehret closed 5 months ago
@lizgehret the image in this viz is in svg, so each element of the viz has actual DOM nodes. That means in theory we can test it with selenium. If we are patching, we shouldn't hold up the patch for that, but it's probably worth adding those tests. If only they had been added ages ago lol.
@lizgehret the image in this viz is in svg, so each element of the viz has actual DOM nodes. That means in theory we can test it with selenium. If we are patching, we shouldn't hold up the patch for that, but it's probably worth adding those tests. If only they had been added ages ago lol.
I agree on both counts - we should add tests, but we should wait until after the patch to do so. Want to walk me through selenium testing next week when I'm back in office?
Sure
fixes #359
So this does work, but I'm not happy with the fact that this had to be added (seemingly) randomly. I'm signing off for the day, but will try to find a better solution that addresses what changed from 2024.2 to 2024.5 tomorrow.