search

qiime2 / q2-feature-classifier

QIIME 2 plugin supporting taxonomic classification
BSD 3-Clause "New" or "Revised" License
18 stars 38 forks source link

Update _blast.py #157

Closed cherman2 closed 4 years ago

cherman2 commented 4 years ago

Here is my documentation for why issue #155 is not accomplishable at this time. Issue #77 was fixed by removing -num_threads as it was ignored when subject was specified. Since num_threads is currently not a variable it can not be exposed.

gregcaporaso commented 4 years ago

@cherman2, it looks like this failed due to a linting error (specific failures are here). We require adherence to the pep8 coding style guidelines to ensure that we have a reasonably consistent coding style throughout the codebase, and your addition needs a couple of modifications to adhere to pep8. You should be able to run make lint in your development environment to test this locally.

Would you mind fixing these issues and then committing and pushing again? That should update this pull request (so you shouldn't need to create a new pull request).

cherman2 commented 4 years ago

This may fail. I wasn't trying to push my new commit, I was just trying to save my code to test it.

cherman2 commented 4 years ago

I could not get make lint to work. I looked up python code linters and found pycodestyle, which conforms to pep8 and used that to test my code. From what I see in the view config tab of travis ci. The system downloads flake 8 in order to use make lint. Pycodestyle is part of that package.