search

qiime2 / q2-gneiss

QIIME2 plugin for Gneiss
BSD 3-Clause "New" or "Revised" License
0 stars 15 forks source link

Making the FeatureTable[Composition] optional in ilr transform #50

Closed mortonjt closed 6 years ago

mortonjt commented 6 years ago

This came out of a discussion with @ebolyen

There are two reasons why we will want this

  1. There are still use cases for utilizing the composition type (we have another plugin coming on board that will output these types). Allowing the ilr transform accept composition types will be very helpful
  2. To ensure backwards compatiability
ebolyen commented 6 years ago

The linter is sad though :(

mortonjt commented 6 years ago

I feel that using github editor is like getting wasted - seems like a good idea until it afterwards ...

mortonjt commented 6 years ago

Thanks!

On Thu, Sep 6, 2018, 8:43 PM Evan Bolyen notifications@github.com wrote:

Merged #50 https://github.com/qiime2/q2-gneiss/pull/50 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/qiime2/q2-gneiss/pull/50#event-1831931339, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_a3YdTgvDJVtGU1v1g46eQ7hy6yzjLks5uYetXgaJpZM4Wd_SL .