BUG: volatility: convert single quotes for valid vega spec

qiime2 / q2-longitudinal

QIIME 2 plugin for paired sample comparisons

BSD 3-Clause "New" or "Revised" License

9 stars 18 forks source link

BUG: volatility: convert single quotes for valid vega spec #111

Closed nbokulich closed 6 years ago

nbokulich commented 6 years ago

fixes #110

did not add unit tests because this never raised an error to begin with — just would not display in view.

tried adding json validation (with json.loads) to validate the spec... but evidently valid vega specs are ruled invalid by json.loads. Any other ideas?

thermokarst commented 6 years ago

Thanks @nbokulich - check out the freshly refactored PR in #105 --- @ebolyen & I hashed out an all new strategy that seems to work pretty darn well for this situation!

nbokulich commented 6 years ago

sweet! two birds one stone eh? Shall we close this PR?