search

qiime2 / q2-longitudinal

QIIME 2 plugin for paired sample comparisons
BSD 3-Clause "New" or "Revised" License
9 stars 18 forks source link

MAINT: updates for scipy 1.5 #157

Closed thermokarst closed 4 years ago

nbokulich commented 4 years ago

Just for posterity: these changes are to address changes to wilcoxon test approximation in scipy v1.5.0: https://docs.scipy.org/doc/scipy/reference/release.1.5.0.html

The wilcoxon function now computes the p-value for Wilcoxon’s signed rank test using the exact distribution for inputs up to length 25. The function has a new mode parameter to specify how the p-value is to be computed. The default is "auto", which uses the exact distribution for inputs up to length 25 and the normal approximation for larger inputs.

thermokarst commented 4 years ago

tests probably won't pass, right? the staging env is set to use the old sscipy.

nbokulich commented 4 years ago

oooh right. thanks! will just merge as-is. Thanks!