search

qiime2 / q2-metadata

BSD 3-Clause "New" or "Revised" License
3 stars 17 forks source link

BUG/ENH: Error handling in tabulate / loading bar #22

Closed thermokarst closed 6 years ago

thermokarst commented 6 years ago

Fixes #21 by adding more robust error handling when parsing JSON that represents the merged and normalized metadata. The client-side exporting has been removed and replaced with a call to Metadata.save, which handles all kinds of edge cases and normalization on our behalf. This exported TSV link is always visible in the viz, that way if the interactive table rendering fails, a user can still get a copy of the merged and normalized metadata.

Addresses #19 by adding in a simple progress indicator, as well as linking that indicator to the loading status and error handling. Note, there isn't any meaningful representation of loading progress at this point, just a binary "loading" / "not loading" type of indicator.

thermokarst commented 6 years ago

Thanks @jairideout! Back in your court.