search

qiime2 / q2-taxa

BSD 3-Clause "New" or "Revised" License
3 stars 29 forks source link

Rearranged schemeAccent to make schemeDescent color palette fixes #111 #129

Closed LeonardoALopezR closed 4 years ago

LeonardoALopezR commented 5 years ago

Referring to #111

Before: Screen Shot 2019-10-08 at 20 33 33

After: Screen Shot 2019-10-08 at 20 34 17

thermokarst commented 5 years ago

Thank you so much, @LeonardoALopezR! Unfortunately this PR doesn't really address the problem: this only changes the order of one color palette, but we need to enable this behavior for all color palettes. I think the area you should take a look at is here: https://github.com/qiime2/q2-taxa/blob/dcf7c7dbd08c59537c21b9028b3a20518d6df189/q2_taxa/assets/barplot/src/render.js#L25-L41

Thanks!

ebolyen commented 5 years ago

Thanks @LeonardoALopezR! I think the primary issue is we want to cycle through colors starting with the most abundant taxa, rather than the least abundant (e.g. reverse the order in which we color each taxa, rather than reverse the color). The goal here is to make it so that highly abundant taxa (i.e. the ones you can actually see) end up with consistent colors for the most part.

Sorry we were slow in getting back to you.

ebolyen commented 5 years ago

@LeonardoALopezR, are you still interested in working on this? If not, no problem at all, we can close the PR :)