Closed wasade closed 3 years ago
Failures are real, left out adjustments for plotting tests, fixing right now
A shortcut fix is inplace. The plotting logic makes a lot of assumptions about having a DataFrame
, and the plotting code isn't designed to support 10s of thousands of samples, so it seemed reasonable to just to to/from conversations to biom.Table
as needed
@thermokarst I think this does it, however I've been unsuccessful at verifying the command locally. I'm observing issues obtaining the contents of the dist
directory after using both a pip install -e .
and pip install .
, is that the right way to install a dev plugin or am I doing something weird and out the the ordinary?
I think this does it
Thanks!
is that the right way to install a dev plugin or am I doing something weird and out the the ordinary?
make dev
should get you what you need w.r.t. npm deps.
ah! thanks :) Can run locally now, and am seeing samples on the x-axis
@wasade - I pushed up some small changes that tie this PR into the existing barplot
visualizer, as well. Please let me know if those edits are acceptable to you - if not we can revert them and resolve elsewhere.
@thermokarst, am :+1:, thanks!!
Ah bummer: https://busywork.qiime2.org/teams/main/pipelines/master-distribution/jobs/integration/builds/356
I haven't dug into this yet, but in case you get there before me, @wasade
Okay, I think I got this over in https://github.com/qiime2/q2-taxa/pull/141
This pull request fixes #135, avoiding a dense representation of the FeatureTable when performing a taxonomy collapse.