qiime2 / q2-types

BSD 3-Clause "New" or "Revised" License
17 stars 41 forks source link

MAINT: refactor names of variables in `reference_db/tests/test_format.py` #319

Closed Sann5 closed 7 months ago

Sann5 commented 7 months ago

In reference_db/tests/test_format.py there are many variables named dirpath. This PR changes all of those variables to path_to_file which is more appropriate since they all contain paths to files and not directories.

Sann5 commented 7 months ago

Hey @Sann5, maybe you can rather rename those to something like filepath or simply fp - no need for all this verbosity 😅

@misialq done :)

Sann5 commented 7 months ago

@misialq shit sorry, here we go again 😅

lizgehret commented 7 months ago

lgtm!