search

qiime2 / q2-types

BSD 3-Clause "New" or "Revised" License
17 stars 41 forks source link

ENH: Added new type `FeatureData[SequenceCharacteristics]` with semantic validator for property 'length'. #326

Closed VinzentRisch closed 6 months ago

VinzentRisch commented 6 months ago

closes #324

install this branch

git clone https://github.com/qiime2/q2-types.git
cd q2-types
git fetch origin pull/326/head:pr-326
git checkout pr-326
pip install -e .

test it out sequence_characteristics.txt

qiime tools import --input-path sequence_characteristics.txt --output-path  sequence_characteristics.qza --type "FeatureData[SequenceCharacteristics % Properties('length')]"
misialq commented 6 months ago

Hey @lizgehret, @ebolyen! This is the PR for the new type we were discussing in our last dev meeting - would one of you maybe have some time to check it out? 🙏

VinzentRisch commented 6 months ago

Hi @lizgehret Thanks for the review. 🙂 I now changed all quotes to be consistent with the other code.

lizgehret commented 6 months ago

changes lgtm, thanks @VinzentRisch and @misialq!