qiime2 / q2-types

BSD 3-Clause "New" or "Revised" License
17 stars 41 forks source link

MAINT: refactor/clean up GenomeData types #338

Closed misialq closed 4 months ago

misialq commented 4 months ago

This PRs refactors some of the GenomeData types and introduces new types which will be required in q2-moshpit. Below is the summary of the changes:

misialq commented 4 months ago

Hey @lizgehret, do you think you could look this over? I think I'll still need to add some tests for the new type introduced here but the rest of the code should be ready.

Just FYI, @nbokulich - these are changes we talked about today, in case you want to check those out.

misialq commented 4 months ago

Hey @lizgehret, I'm done with the changes here - I added one test for the new directory format and refactored some paths to test files for consistency.

misialq commented 4 months ago

Hmmm this is very weird - some tests are failing due to some directories supposedly not being there. I looked through setup.py and the tests themselves but cannot really see what the problem is. They also pass locally for me. Do you spot what's wrong @lizgehret? 👀

lizgehret commented 4 months ago

i think i found the issue(s) @misialq - letting the tests run now to confirm!

misialq commented 4 months ago

Aaaaaaah, all these commas 🤦 Thanks for fixing! Feel free to merge any time 🚀