ENH: Expose --threads for join_pairs, closes #43

qiime2 / q2-vsearch

vsearch plugin for QIIME 2

BSD 3-Clause "New" or "Revised" License

6 stars 20 forks source link

ENH: Expose --threads for join_pairs, closes #43 #63

Closed colinbrislawn closed 5 years ago

colinbrislawn commented 5 years ago

Feedback welcome!

EDIT: Fixed a two year old lint issue from Greg himself. Neat! 🤷‍♂

What do you think of this part?

threads': qiime2.plugin.Int % qiime2.plugin.Range(
0, 8, inclusive_start=True, inclusive_end=True)
...
        'threads': ('The number of threads to use for computation. Does '
                    'not scale much past 4 threads.')

colinbrislawn commented 5 years ago

Merge when ready!

ebolyen commented 5 years ago

FYI, busywork is a little hung up at the moment, so it may be a few days before this is in our staging environments.

colinbrislawn commented 5 years ago

My first real PR to qiime. Thanks for seeing me through it.