imp: adds more options to `dereplicate_sequences()`

qiime2 / q2-vsearch

vsearch plugin for QIIME 2

BSD 3-Clause "New" or "Revised" License

6 stars 20 forks source link

imp: adds more options to `dereplicate_sequences()` #86

Closed colinbrislawn closed 2 years ago

colinbrislawn commented 2 years ago

EDIT:

Description: Add --min_seq_length and --min_unique_size settings to vsearch dereplicate-sequences to discard short or uncommon sequences from the dereplication output.

Closes #47 --minseqlength for derep Also closes #68 --minuniquesize for derep

Ready for review, all feedback welcome!

EDIT: Hashing is hard, I'll do that in a second PR.

lizgehret commented 2 years ago

Thanks @colinbrislawn! We are doing some PR triage and review right now and will take a look at this soon.

Oddant1 commented 2 years ago

@colinbrislawn, is this ready to merge?

lizgehret commented 2 years ago

Hey @colinbrislawn, one final request - do you mind adding in a quick description in this PR that describes what this does and who it affects so we can include that in the 2022.11 release changelog? 🙂

colinbrislawn commented 2 years ago

@lizgehret, done! Let me know how it looks!

lizgehret commented 2 years ago

That's perfect, thanks @colinbrislawn!

colinbrislawn commented 2 years ago

Looks like I messed up the line ending in plugin_setup.py in the other PR.

Whoops! I'll look into this and get it merged.

colinbrislawn commented 2 years ago

I think this is now ready to merge!