IMP: tools import and cache-import now have validate_level

qiime2 / q2cli

Command line interface for QIIME 2

BSD 3-Clause "New" or "Revised" License

19 stars 24 forks source link

IMP: tools import and cache-import now have validate_level #324

Closed ebolyen closed 9 months ago

ebolyen commented 9 months ago

Depends on https://github.com/qiime2/qiime2/pull/734

TODO:

[x] write tests with a sacrificial format with hidden errors
[x] cache import tests?

Oddant1 commented 9 months ago

Added cache import min validation tests identical to normal import.

gregcaporaso commented 9 months ago

@Oddant1, @ebolyen - sounds like this is ready for merge when the merge conflict is resolved. Is that right? It looks like the failures are related to the the changes in qiime2 not being available yet in the environment where the tests are run.

ebolyen commented 9 months ago

Yeah, I think that's correct

Oddant1 commented 9 months ago

I'll deal with the merge conflicts

gregcaporaso commented 9 months ago

Tested locally, looks good!