search

qiime2 / q2cli

Command line interface for QIIME 2
BSD 3-Clause "New" or "Revised" License
19 stars 24 forks source link

update replay supplement tests for nested zipfile directory #325

Closed colinvwood closed 9 months ago

colinvwood commented 9 months ago

updates for qiime2/qiime2#732

colinvwood commented 9 months ago

blocked by qiime2/qiime2#732

lizgehret commented 9 months ago

@gregcaporaso @colinvwood test failures are due to CI not pulling the latest version of qiime2 that contains the requisite changes that this PR depends on. @ebolyen is working on a fix for this, but in the meantime if you can confirm that these tests pass on both osx and ubuntu (testing locally), this should be good to merge.

EDIT: @gregcaporaso you mentioned that you'd already tested this locally on osx, so we should just have this tested on ubuntu before merging. @Oddant1 can you pull this down with the requisite framework changes and confirm that tests pass locally?

gregcaporaso commented 9 months ago

Thanks @lizgehret and @ebolyen! I just confirmed again that the q2cli tests pass locally for me when working with the latest dev branch of the framework.

colinvwood commented 9 months ago

there's no rush to merge this, these are just tests for a small change in the framework... I guess CI will fail here until this is merged though

Oddant1 commented 9 months ago

@lizgehret tests passed for me

lizgehret commented 9 months ago

Okay @gregcaporaso this should be good to merge!