search

qiime2 / q2cwl

Prototype interface for automatically generating CWL tools from QIIME 2 actions
BSD 3-Clause "New" or "Revised" License
8 stars 7 forks source link

Updating copyright & license year #13

Closed lizgehret closed 3 years ago

lizgehret commented 3 years ago

Adding copyright header to missing files & updating license year to include 2021

Keegan-Evans commented 3 years ago

Did you run flake8 on these?

lizgehret commented 3 years ago

@Keegan-Evans great catch, thank you! I did not - will run that on these PRs and then submit any needed changes.

lizgehret commented 3 years ago

Flake8 errors:

  1. ./q2cwl/cli.py:17:25: F821 undefined name 'Status'

Line:

def echo_status(status: 'Status', quiet: bool = False):

2. ./q2cwl/template.py:158:13: F841 local variable 'default' is assigned to but never used

Lines:

else:            
  default = spec.default

Leaving these as-is unless these pose issues with the code as it currently stands (but doesn't seem that way).

thermokarst commented 3 years ago

Flake8 errors:

I'm good with leaving these as-is for now. Flake8 isn't part of this assignment, so getting that squared away is a "bonus" in my eyes. Thanks!