Open colinvwood opened 5 hours ago
I think this was the end result of an awful lot of fighting with Sphinx.
You're right that they are ultimately instance methods.
It also doesn't look like the docs use those attributes directly anymore, so I think we can change it: https://develop.qiime2.org/en/latest/plugins/references/api/plugin.html#action-registration
Will just want to make sure everything still looks right.
The
methods
,visualizers
, andpipelines
class attributes of thePlugin
class are typed as classes (here) but the methods called on these class attributes (e.g.register_function
) are instance methods, and the attributes themselves are instances when used inplugin_setup.py
files. Thus e.g.Type['PluginMethods']
should probably just be typed as 'PluginMethods'.