Open sjanssen2 opened 5 months ago
Thank you @sjanssen2. Do you think is worth supporting older versions of h5py or just support the latests? I vote to just support the latests - thus, not needing packaging and checking.
Hi @antgonza I tend to agree that we don't have to support older versions, however I don't feel to competent to consider all edge cases. Thus, I chose the more conservative method. Your choice :-) But I'd be happy to get rid of this test altogether.
In my experience, is better to just rip off the bandaid and then deal with any tentative issues if/when they arise. So, please remove that extra conditional and the need of packaging. Thanks.
Just to confirm before merging, what version of h5py should we be using and are there any other updated dependencies for that?
Also, I just realized that the actions are not testing against python 2.7 and while the plan is to stop supporting ASAP we still have at least 1 plugin that uses it.
When starting Qiita, the log reports about a deprecated use of
h5py.get_config().default_file_mode = 'r'
. This function was indeed deprecated with version 3.0.0. I therefore use thepackaging
lib to check if the used h5py version is older than that before trying to manually set to 'r'.Should you feel we anyways would not use older h5py versions, we can delete these lines 15-20 in
qiita_files/util.py
altogether