search

qiita-spots / qiita-files

File formats defined for Qiita and Qiita plugins internal use
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Normalize demux API #5

Closed josenavas closed 7 years ago

josenavas commented 7 years ago

The current API for the demux mainly accepts an h5py.File as parameter, which puts the burden of opening the hdf5 file to the consumer of the API. I think it will make more sense to actually pass in the filepath of the hdf5 file and handle the file opening/closing internally. This will allow us to parallelize more stuff internally, as we did for the to_per_sample_files function (which is the only exposed API function that allows a filepath rather than a h5py.File object.

@wasade, @antgonza Any objections to this?

wasade commented 7 years ago

:+1: as h5py.File is not pickleable

antgonza commented 7 years ago

None.