search

qiita-spots / qiita

Qiita - A multi-omics databasing effort
http://qiita.microbio.me
BSD 3-Clause "New" or "Revised" License
120 stars 80 forks source link

Unify different target genes into "Target Gene" #1569

Open ackermag opened 8 years ago

ackermag commented 8 years ago

e.g. select 16S, should be 18S;

Would be much cleaner if prep-template is fine and data is fine to just reprocess with different options (rev comp) or for different target gene (16S, 18S, ITS)

antgonza commented 8 years ago

@ackermag I think there are 2 issues here:

  1. be able to redefine the data type in a prep info file, which should be propagated to all artifacts from that prep info file
  2. be able to reprocess the same prep-info/raw-data using different parameters: this is currently possible

If you agree, I'll change the issue name.

josenavas commented 8 years ago

I think this goes back to the fact that from the system point of view there is no difference between 16S, 18S or ITS - it doesn't affect anything on the processing pipeline. We should allow changing that as long as they are under the same type (i.e. we can change the description to target_gene.{16S,18S,ITS} and allow to change it as long as is in the target_gene.X series).

antgonza commented 8 years ago

Right, do we have that definition somewhere or is that something we have to do? If we need to do, should that be a different issue?

antgonza commented 7 years ago

@josenavas, ping! What do you think?

antgonza commented 7 years ago

Renaming the issue for clarity.

josenavas commented 7 years ago

How do we want to handle this? To be fair, the plugins don't even care about it, as it is applied in a per artifact basis. However, we can wrap this information as part of the type decorators that we were talking so plugins are aware of them, but let's revisit this after tomorrow's meeting.

antgonza commented 7 years ago

Possible. Let's discuss during the Qiita meeting. Moving to Alpha 0.4.