Closed justinshaffer closed 4 years ago
antgonza
commented
4 years ago Thanks @justinshaffer. Adding @ElDeveloper as he was also in the internal discussion about this.
As you mentioned the solution is easy to just change the text; however, I'm wondering what would be the best behavior: do not merge or merge by default ... for me, not merging.
Thoughts?
justinshaffer
commented
4 years ago Hi Antonio - yes I agree that the default should be to not merge.
Thanks!
Justin
On Fri, Mar 13, 2020 at 8:51 AM Antonio Gonzalez notifications@github.com wrote:
Thanks @justinshaffer https://github.com/justinshaffer. Adding @ElDeveloper https://github.com/ElDeveloper as he was also in the internal discussion about this.
As you mentioned the solution is easy to just change the text; however, I'm wondering what would be the best behavior: do not merge or merge by default ... for me, not merging.
Thoughts?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/qiita/issues/2978#issuecomment-598789885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSDCGCPFULTEEEPIBQD2D3RHJI6RANCNFSM4LGRS45A .
-- Justin Shaffer, PhD IRACDA Postdoctoral Fellow Rob Knight Group Department of Pediatrics, School of Medicine University of California, San Diego justinshafferbio.wordpress.com
ElDeveloper
commented
4 years ago :+1:
On (Mar-13-20| 9:12), Justin Shaffer wrote:
Hi Antonio - yes I agree that the default should be to not merge.
Thanks!
Justin
On Fri, Mar 13, 2020 at 8:51 AM Antonio Gonzalez notifications@github.com wrote:
Thanks @justinshaffer https://github.com/justinshaffer. Adding @ElDeveloper https://github.com/ElDeveloper as he was also in the internal discussion about this.
As you mentioned the solution is easy to just change the text; however, I'm wondering what would be the best behavior: do not merge or merge by default ... for me, not merging.
Thoughts?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/qiita/issues/2978#issuecomment-598789885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSDCGCPFULTEEEPIBQD2D3RHJI6RANCNFSM4LGRS45A .
-- Justin Shaffer, PhD IRACDA Postdoctoral Fellow Rob Knight Group Department of Pediatrics, School of Medicine University of California, San Diego justinshafferbio.wordpress.com
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/2978#issuecomment-598799976
Hello,
Background: I'm conducting a meta-analysis across eight preps in a single study. The sample information file contains data for 384 samples. Each prep has the same 384 samples. The sample IDs are the same across the sample information file and all of the prep information files. My understanding was that this was OK, as long as samples are only duplicated across preps rather than in a single one.
Problem: When adding the final Deblur tables from each of the eight preps into an analysis, and not clicking the check-box to 'Merge samples with the same name', the resultant merged table only includes 384 samples and metadata from a single prep (e.g., only a single value for run_prefix even though there should be eight). I was able to reproduce this problem several times. I then decided to check the box to 'Merge samples with the same name', and it kept the samples across preps separate resulting in the expected 3,072 samples, and the merged metadata.
Potential solution: The functionality of the check-box to 'Merge samples with the same name' appears to work opposite to as it states. Switching this would likely fix this issue.
Thanks in advance for any help on resolving this issue!