qiita-spots / qiita

Qiita - A multi-omics databasing effort
http://qiita.microbio.me
BSD 3-Clause "New" or "Revised" License
120 stars 80 forks source link

rm get_reference_fp and ontology download deprecated functionality #3374

Open sjanssen2 opened 4 months ago

sjanssen2 commented 4 months ago

I think the local filenames of the GG 13.8 reference, used in the qp-target-sequencing plugin, is out of sync between qiita environment manager here: https://github.com/qiita-spots/qiita/blob/57d1b146729223da9daa286a1cc75db6f2923746/qiita_db/environment_manager.py#L100-L108

and in the plugin itself:

https://github.com/qiita-spots/qp-target-gene/blob/858436ee6d4a1fccd35faee0b156a12953b5774a/qp_target_gene/__init__.py#L148-L149

I figure the plugin is correct, see this screenshot from qiita.ucsd.edu image

sjanssen2 commented 4 months ago

hm, is there maybe even a way to overwrite these filepaths, provided by the plugin, when registering into qiita? Thus, the filepaths could point to those files that have actually downloaded through qiita-env make --download-references?!

antgonza commented 4 months ago

In the original (like 10 years ago) Qiita design, the idea was that everything was self contained; however, we then realized that using plugins was the way to go. The old download-references is really deprecated.

Maybe this is a good opportunity, if you have the chance, to remove those old functionalities and just rely on the newest code. BTW this issue reminded me of this other one: https://github.com/qiita-spots/qiita/issues/3197.

antgonza commented 4 months ago

FWIW I think your effort might be better focus if we had a quick call to see what you are trying to achieve and maybe summarize all your open issues into one. Anyway, you have my email ...

antgonza commented 1 month ago

After https://github.com/qiita-spots/qiita/pull/3403 was merged, we should be able to easily and (almost) cleanly remove the old and deprecated ontology and reference download and processing; thus, changing the name of this issue so it can be addressed.