search

qiita-spots / qp-deblur

2 stars 7 forks source link

Comm archive #37

Closed sjanssen2 closed 6 years ago

sjanssen2 commented 6 years ago

Adding a new (currently not used) parameter for the reference tree/alignment for SEPP placements. Actually talk to archive to retrieve pre-computed placements, compute placements via SEPP for novel fragments and store novel placements in archive.

sjanssen2 commented 6 years ago

This PR will fail as long as https://github.com/biocore/qiita/pull/2460 is not merged.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.5%) to 98.901% when pulling 9b4e64e387e4db15cebea98771182ac3df2a68a9 on sjanssen2:comm_archive into 6374306b1b9980cce0001141d975df14b2b3e78c on qiita-spots:master.

sjanssen2 commented 6 years ago

ready for another round of reviews @antgonza

sjanssen2 commented 6 years ago

fixed coverage and decreased try blocks. What do you think @antgonza ?

sjanssen2 commented 6 years ago

Thank you!