search

qiita-spots / qp-deblur

2 stars 7 forks source link

Fix mode #7

Closed josenavas closed 7 years ago

josenavas commented 7 years ago

@ElDeveloper you'll laugh about this one hahaha

It turns out that biom_open doesn't support that mode... fun fun

mortonjt commented 7 years ago

Should we open up an issue to fix that?

josenavas commented 7 years ago

@wasade?

ElDeveloper commented 7 years ago

👍

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.96% when pulling 39ef4b9d93dadd9a92374bf9f0ee9e93282a1333 on josenavas:fix-empty into 6a637a6acb98321644a6dd446bb9698ffc11877a on qiita-spots:master.

wasade commented 7 years ago

why were you trying to open the file for read and write?

josenavas commented 7 years ago

In HDF5, there is only 2 modes to open the file: 'r' read-only and 'r+' read-write: http://docs.h5py.org/en/latest/high/file.html#File.mode

wasade commented 7 years ago

guess an issue should be created :)

wasade commented 7 years ago

um... no, the full suite is supported (from the link you pasted):

"mode – Mode in which to open file; one of (“w”, “r”, “r+”, “a”, “w-”). See Opening & creating files."

and

>>> import h5py
>>> f = h5py.File('modetest', 'w')
josenavas commented 7 years ago

Thanks @antgonza

You're right @wasade - however, if you read down on the description of the "mode" parameter, it says that it will only be using r, or r+, but I guess it makes more sense to just use the w.