search

qiita-spots / qp-qiime2

Qiime 2 plugin for Qiita
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

make sure that we copy the input tree file vs. mv when creating a new biom #48

Closed antgonza closed 4 years ago

ElDeveloper commented 4 years ago

Looks good, is there an easy way to add a test?

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.4%) to 95.49% when pulling 3a100e67f0ec81f81233b615f2f72e0335787f27 on antgonza:fix-mv-input-tree into 2d19593180822fef289fe4812be8d638d0e66000 on qiita-spots:master.

antgonza commented 4 years ago

"Easy", sadly AFAIK no. The issue is that we only have (1) a deblur table without tree and (2) a close reference table for testing. For (1) we would need to create a new tree, trim it down (to avoid size issues), add it to qiita (main qiita, not this plugin, which will represent changing a bunch of tests as this will be a new file in the system); then use it in test_feature_classifier to test these new lines. Then for (2) these new lines are not relevant.

ElDeveloper commented 4 years ago

Thanks, I opened a separate ticket for this 👍