search

qiita-spots / qp-qiime2

Qiime 2 plugin for Qiita
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

add umap #63

Closed antgonza closed 3 years ago

gwarmstrong commented 3 years ago

UMAP needs and additional dependency that is not a part of the base qiime2 installation. It looks like the workflow used pip to install it. Is that sufficient or do you need to add the dependency explicitly somewhere?

the dependency is umap-learn and can be installed with conda install -c conda-forge umap-learn or apparently pip install umap-learn

antgonza commented 3 years ago

Thank you for review and good catch ... I think using pip as the dependency solver is the (best?) way to go as this makes it simple to install so it's fine.