search

qiita-spots / qp-qiime2

Qiime 2 plugin for Qiita
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

2022.2 #68

Closed antgonza closed 2 years ago

antgonza commented 2 years ago

Updating to 2022.2

charles-cowart commented 2 years ago

Right, but you have a statement that can never be reached afterwards. Would you mind removing it, please? Thank you!

On Jun 3, 2022, at 11:12 AM, Antonio Gonzalez @.***> wrote:

 @antgonza commented on this pull request.

In qp_qiime2/init.py:

@@ -155,6 +172,10 @@

this is an odd one, first encountered:

feature-classifier fit-classifier-naive-bayes

if ename == element.NOVALUE:

  • As of qiime2-2022.2 nothing is filtered here, so let's raise

  • an error so we can catch and review if this happens in the

  • future

  • raise ValueError(f"[REVIEW] {pname} {mid} due to {ename}") add_method = False yes, if this happens we want everything to stop and have someone look - cause it should never happen.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.