search

qiita-spots / qp-qiime2

Qiime 2 plugin for Qiita
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

fix #3266 #78

Closed antgonza closed 1 year ago

antgonza commented 1 year ago

This does the bare minimum to fix https://github.com/qiita-spots/qiita/issues/3266.

ElDeveloper commented 1 year ago

Wait!

ElDeveloper commented 1 year ago

Sorry for the confusion, I just remembered that EMPeror uses this property as a way to determine whether it should use qiime emperor plot or qiime emperor biplot. Coercing the type and removing the property will lead to an error from qiime emperor plot. The correct thing would be to use qiime emperor biplot when that property is present. Alternatively an additional flag can be passed to qiime emperor plot to ignore biplot arrows but I think that wouldn't be the expected behavior.

antgonza commented 1 year ago

I deployed this solution in qiita-rc and the command is working again, including the "summary" which is done here and perhaps the reason it works fine.

As a reminder, we automatically summarize the QZA's in Qiita so we get something that the user can see without having to summarize it themselves. For example, a PCoA will be automatically summarized via the lines above but the user can still use emperor plot in case they want to use any of the non default parameters. BTW we don't currently expose the emperor biplot command in Qiita but we can - I'll check it and issue another PR if it's possible.