qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
32 stars 3 forks source link

[QHC-64]Compilation at platform level #651

Closed visagim closed 9 months ago

visagim commented 10 months ago

Summary

linear[bot] commented 10 months ago

QHC-64 Compiler at platform level

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (097bee6) 95.82% compared to head (382d1f0) 95.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #651 +/- ## ========================================== + Coverage 95.82% 95.98% +0.16% ========================================== Files 270 271 +1 Lines 8815 8797 -18 ========================================== - Hits 8447 8444 -3 + Misses 368 353 -15 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/651/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/651/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `95.98% <100.00%> (+0.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

visagim commented 10 months ago

This is a very big PR changing core functionalities of qililab. I think we should make 2 people review and approve the PR before merging it.

Yes, 100% agree with that. I also think testing it for some time on hardware before merging would be a good idea