Closed visagim closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.16%. Comparing base (
83316aa
) to head (4f46836
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sorry to ask this after having the implementation, but could we consider a more clean approach, so we don't need to have assumptions about namings? There is an easy and quick solution that should work with any bus/acquisition name:
If we add a
port
parameter in theget_qprogram_acquisitions()
method ofReadoutSystemControl
we can move the information of the specific sequencer to acquire from down to the instrument. In the same way we do in theupload()
method:# Bus calls the system control with port=self.port self.system_control.upload_qpysequence(qpysequence=qpysequence, port=self.port) # SystemControl passes the port to the instrument method def upload_qpysequence(self, qpysequence: QpySequence, port: str): """Uploads the qpysequence into the instrument.""" for instrument in self.instruments: if isinstance(instrument, AWG): instrument.upload_qpysequence(qpysequence=qpysequence, port=port) return raise AttributeError("The system control doesn't have any AWG to upload a qpysequence.") # QbloxModule finds the correct sequencer using the port def upload_qpysequence(self, qpysequence: QpySequence, port: str): sequencers = self.get_sequencers_from_chip_port_id(chip_port_id=port) for sequencer in sequencers: ...
I am asking this, because I think it's super easy to implement. If you think it will complicate things we can move on with the current one. I just want to avoid having restrictions in namings. Because many examples and demos just use a drive_bus
/ readout_bus
.
Temporary fix, assumes 2 things:
readout_q0_bus
getsqubit=0