Drivers/move_params_and_alias_to_abc

qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.

Apache License 2.0

30 stars 2 forks source link

Removing the repeated `alias` and `params` properties from each driver, to use the qcodes base `name` and `parameters`

My only question is if the word `alias` and `params` are needed:

for some higher level functionality in qililab, and we cannot remove them completely,
or if name give incompatibilities with another name attribute or something somewhere (I don't think so).

In such a case we then simple would need to keep this mapping:

    @property
    def params(self):
        """return the parameters of the instrument"""
        return self.parameters

    @property
    def alias(self):
        """return the alias of the instrument, which corresponds to the QCodes name attribute"""
        return self.name

But just once in a base class please, instead than repeating it for each individual driver (and if there is a weird case, then it can be overwritten there, but so far, all drivers have had the same repeated...)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.11%. Comparing base (f4c356d) to head (fff3814).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #698 +/- ## ========================================== - Coverage 96.16% 96.11% -0.05% ========================================== Files 273 273 Lines 9043 8941 -102 ========================================== - Hits 8696 8594 -102 Misses 347 347 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/698/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/698/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `96.11% <100.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

qilimanjaro-tech / qililab